[ntuple] Add support for attributes reading#21778
Merged
silverweed merged 10 commits intoroot-project:masterfrom Apr 21, 2026
Merged
[ntuple] Add support for attributes reading#21778silverweed merged 10 commits intoroot-project:masterfrom
silverweed merged 10 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 7h 45m 29s ⏱️ For more details on these failures, see this check. Results for commit f741897. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
ntuple_attr_read
branch
4 times, most recently
from
487b964 to
5da9754
Compare
silverweed
force-pushed
the
ntuple_attr_read
branch
3 times, most recently
from
d68c286 to
28e4497
Compare
hahnjo
requested changes
Apr 9, 2026
silverweed
force-pushed
the
ntuple_attr_read
branch
3 times, most recently
from
e1b0b9f to
8ed4073
Compare
hahnjo
reviewed
Apr 10, 2026
silverweed
force-pushed
the
ntuple_attr_read
branch
5 times, most recently
from
64e105f to
78b7eb3
Compare
hahnjo
approved these changes
Apr 20, 2026
Member
hahnjo
left a comment
hahnjo
left a comment
There was a problem hiding this comment.
Code looks good to me, some last comments. Please wait for Jakob's review + approval
silverweed
force-pushed
the
ntuple_attr_read
branch
from
78b7eb3 to
40cfdc9
Compare
jblomer
approved these changes
Apr 20, 2026
Contributor
jblomer
left a comment
jblomer
left a comment
There was a problem hiding this comment.
Very nice!
Next step would be adding a tutorial.
silverweed
force-pushed
the
ntuple_attr_read
branch
from
40cfdc9 to
74d426a
Compare
This makes it easier to keep the meta fields names and indices in sync and to automatically define and verify their count
silverweed
force-pushed
the
ntuple_attr_read
branch
from
74d426a to
f741897
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for RNTuple attribute reading in the form of the
ROOT::Experimental::RNTupleAttrSetReaderclass plus some ancillary classes.Main features added:
RNTupleReader::OpenAttributeSet-> returns an RNTupleAttrSetReader for a specific attribute setRNTupleAttrSetReader::GetAttributes*-> various methods that return iterables over attribute entry indicesRNTupleAttrSetReader::LoadEntry(index[, entry])-> loadsindex-th attribute entry (similar toRNTupleReader::LoadEntry). Meant to be used withRNTupleAttrSetReader::GetAttributes*See the tests for basic usage, e.g.
BasicReadingWritinginntuple_attributes.cxx